reconcile with dev-access-esm1.6 - util- snmin threshold thru namelist #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JhanSrbinovsky
changed the title
|
@ccarouge benchcab is failing. can you see /g/data/p66/jxs599/bench_example/benchmark_cable_qsub.sh.o135997354? same error twice with change 42 site to 5 site test |
JhanSrbinovsky
changed the title
|
Hi @JhanSrbinovsky, I don't have access to |
|
@SeanBryan51 I've cp-ed the whole directory to here: /scratch/public/jxs599/bench_example |
@JhanSrbinovsky still no luck, can you check the permissions on the directory? |
|
Should be OK – I though //scratch/public forced a umask on whatever you put there. |
|
I've so far had no issues testing |
|
@SeanBryan51 sorry I wasn't clear. It appears to run - but checking PBS log files for reporting on bitwise compatability - It isnt there. checking runs/fluxsite/outputs/ - also empty this is entire file "benchmark_cable_qsub.sh.o136083597" 35L, 2459C 35,1 All /g/data/hh5/public/apps/miniconda3/envs/analysis3-24.07/bin/benchcab fluxsite-run-tasks --config=config.yaml ====================================================================================== |
|
update -the payu laboratory seem to have worked |
|
I seem to get different output, and yes I am also getting differences between model outputs. From running the 42 sites I get the following summary in the PBS log file: |
|
It could be some state left from the previous run that could be messing up things. I recommend running |
|
I did the cleaning several times. I've just moved it to /scratch. I'm still waiting on jobs to finish before it write a .o file, but there are at least files in the output directory now. Bugger, I was 100% expecting see al 42 sites "identical" so this is going to be the next problem |
|
just got the .o file and it looks like it should. It seems it doesnt like being on /g/data/ ? |
|
@SeanBryan51 - where does benchcab pickup call.nml from - because that is what the change is and if it doesnt pick up src/offline/cable.nml then it initialising a threshold with some random number - Im surprised there armed ,ore Failures |
|
The 28 failures are due to the snow aging changes. I'm guessing that change is in main but not in this PR. If you compare to the root commit of this branch, it shouldn't give any changes. The reason I know if I ran benchab on #551 and it showed the same puzzling differences. Traced it back to the extra changes in main rather than changes in the branch. But I haven't checked what's in this current PR yet. |
|
@JhanSrbinovsky to answer your question benchcab picks up the namelist from bench_example, both |
|
@JhanSrbinovsky To test changes to the namelist, use the |
@ccarouge I suspect YYYY here means substituting snmin=1.0? It isnt a part of cable_user type though? |
I think I already rebased the branch - so it picked that up. I'll try ro rerun it with the patch thing. |
|
hmmmm - looking in runs/......./tasks/....../cable.nml it doesnt look like cable_user%exsting_feature is gonna do it. |
seems to have added what I need to cable.nml, we'll wait for the output |
JhanSrbinovsky
force-pushed
the
sync_ESM16_util
branch
from
b3b7bf8 to
ac2a644
Compare
|
2025-03-03 16:40:25,871 - INFO - benchcab.benchcab.py:391 - 0 failed, 20 passed OK - thats better. I mixed up the branches I was testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In ESM1.6 we have upgraded snmin(the threshold snow depth triggering 3-layer treatment) to a runtime configurable constant.
Merging ESM1.6 code we already have modifications to cable_common and cable_runtime_opts. Strictly speaking, it shouldn't be necessary to make any mods to offline at all.
However, with some very minor modifications (on top of those that are already coming through the merge anyway), we can implement snmin as a runtime configurable constant in offline as well.
put snmin=1.0 in cable.nml to reproduce main.
Type of change
Enhancement following ESM1.6
Checklist
Testing
2025-03-03 16:40:25,871 - INFO - benchcab.benchcab.py:391 - 0 failed, 20 passed
📚 Documentation preview 📚: https://cable--552.org.readthedocs.build/en/552/